✨ feat: 체감온도 계산식 구현 및 api 구현 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinho7
approved these changes
Jul 9, 2024
| @@ -51,12 +51,4 @@ public void airKoreaTest(@RequestBody AirTestRequest request) throws URISyntaxEx | |||
| public void accuweatherTest(@RequestBody AccuweatherTestRequest request) throws URISyntaxException, IOException { | |||
| weatherService.convertLocation(request.latitude(), request.longitude()); | |||
| } | |||
|
|
|||
| @GetMapping("/converㅅ") | |||
There was a problem hiding this comment.
LocalDateTime을 문자열로 변환하는 로직이 있는데, 이를 별도의 유틸리티 클래스로 분리하면 좋을 것 같습니다!
There was a problem hiding this comment.
public class DateTimeUtil {
public static String convertLocalDateTimeToString(LocalDateTime time) {
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyyMMdd_HHmm");
return time.format(formatter);
}
public static LocalDateTime convertLocalDateTimeToDailyWeatherTime(LocalDateTime time) {
List<Integer> scheduledHours = Arrays.asList(0, 3, 6, 9, 12, 15, 18, 21);
int currentHour = time.getHour();
int adjustedHour = scheduledHours.stream()
.filter(hour -> hour <= currentHour)
.reduce((first, second) -> second)
.orElse(scheduledHours.get(scheduledHours.size() - 1));
if (currentHour < scheduledHours.get(0)) {
time = time.minusDays(1);
}
return time.withHour(adjustedHour).withMinute(0).withSecond(0).withNano(0);
}
}
|
결국 돌고 돌아 api로.. 인정입니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️Issue Number
🔎 Key Changes
💌 To Reviewers